Correct references in cmd README.md #6539
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These links are currently broken. I didn't actually test these commands, but jaegertracing#6523 looks like a simple rename, so might be fine. Signed-off-by: Jeff Youngs <[email protected]>
yurishkuro
approved these changes
Jan 13, 2025
|
Thanks. This was missed in #6523 |
ekefan
pushed a commit
to ekefan/jaeger
that referenced
this pull request
Jan 14, 2025
These links are currently broken. I didn't actually test these commands, but jaegertracing#6523 looks like a simple rename, so might be fine. ## Which problem is this PR solving? - n/a ## Description of the changes - README updates ## How was this change tested? - It wasn't ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: Jeff Youngs <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These links are currently broken. I didn't actually test these commands, but #6523 looks like a simple rename, so might be fine.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test