[refractor] Remove dependency on tlscfg.Options #6478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saumya Shah <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6478 +/- ##
==========================================
- Coverage 96.31% 96.27% -0.04%
==========================================
Files 370 370
Lines 21170 21169 -1
==========================================
- Hits 20389 20380 -9
- Misses 598 604 +6
- Partials 183 185 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Saumya Shah <[email protected]>
yurishkuro
reviewed
Jan 4, 2025
yurishkuro
reviewed
Jan 4, 2025
Signed-off-by: Saumya Shah <[email protected]>
Signed-off-by: Saumya Shah <[email protected]>
yurishkuro
previously approved these changes
Jan 4, 2025
|
CI is failing |
|
please get the CI tests & lint checks green |
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
changed the title
Signed-off-by: Saumya Shah <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
approved these changes
Jan 5, 2025
|
Thanks! |
adityachopra29
pushed a commit
to adityachopra29/jaeger
that referenced
this pull request
Jan 9, 2025
## Which problem is this PR solving? - Resolves jaegertracing#6468 ## Description of the changes - Removes the dependency of various `jaeger` packages on tlscfg.Options - Options is now `private` struct in tlscfg - In place of `tlscfg.Options` corresponding `configtls` by OTEL is used ## How was this change tested? - Running `go test -v` in all the packages which were changed/dependent on tlscfg.Options ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Saumya Shah <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Signed-off-by: adityachopra29 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
jaegerpackages on tlscfg.Optionsprivatestruct in tlscfgtlscfg.Optionscorrespondingconfigtlsby OTEL is usedHow was this change tested?
go test -vin all the packages which were changed/dependent on tlscfg.OptionsChecklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test