[v1][adjuster] Change v1 adjuster interface to not return error and modify trace in place #6426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mahad Zaryab <[email protected]>
4 tasks
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6426 +/- ##
==========================================
- Coverage 96.27% 96.24% -0.03%
==========================================
Files 368 368
Lines 21008 20977 -31
==========================================
- Hits 20225 20189 -36
- Misses 599 603 +4
- Partials 184 185 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
yurishkuro
reviewed
Dec 27, 2024
model/adjuster/adjuster.go
Outdated
| type Adjuster interface { | ||
| Adjust(trace *model.Trace) (*model.Trace, error) | ||
| Adjust(trace *model.Trace) *model.Trace |
There was a problem hiding this comment.
Any reason to return the trace? I don't think any adjusters actually create a new one, they always return the original trace that may be changed in place. So I would make it consistent with the v2 Adapter API to simplify things.
There was a problem hiding this comment.
@yurishkuro was thinking the same thing as well - done
Signed-off-by: Mahad Zaryab <[email protected]>
mahadzaryab1
changed the title
yurishkuro
approved these changes
Dec 27, 2024
Manik2708
pushed a commit
to Manik2708/jaeger
that referenced
this pull request
Jan 5, 2025
…odify trace in place (jaegertracing#6426) ## Which problem is this PR solving? - Towards jaegertracing#6417 ## Description of the changes - The v1 adjuster interface returns an error even though none of the adjusters ever return an error. This was leading to handling errors that would never be thrown. This PR simplifies the interface by removing the error return. - The v1 adjuster interface was also returning the trace that it modified. However, all the adjusters currently just take the trace in as a pointer and modify it in place so this return was not necessary. ## How was this change tested? - CI ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Mahad Zaryab <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test