-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[v2][query] Implement helper to buffer sequence of traces #6401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
82bf495
Implement Skeleton For Trace Aggregator
mahadzaryab1 a1adc6a
Address Feedback From PR Review
mahadzaryab1 16177a4
Add Functionality To Merge Traces In Aggregator
mahadzaryab1 14d8b5b
Update Contract of Reader
mahadzaryab1 805a84c
Add Unit Tests
mahadzaryab1 8d710f9
Add Unit Tests
mahadzaryab1 f3c6fc2
Merge branch 'main' into join-seqs
mahadzaryab1 2cdb949
Remove Accidental Commit
mahadzaryab1 b320f63
Add Test To Satisfy Missing Code Coverage
mahadzaryab1 0a5b4f9
Address Feedback From PR Review
mahadzaryab1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
package jptrace | ||
|
||
import ( | ||
"iter" | ||
|
||
"go.opentelemetry.io/collector/pdata/pcommon" | ||
"go.opentelemetry.io/collector/pdata/ptrace" | ||
) | ||
|
||
func AggregateTraces(tracesSeq iter.Seq[[]ptrace.Traces]) iter.Seq[ptrace.Traces] { | ||
return func(yield func(trace ptrace.Traces) bool) { | ||
currentTrace := ptrace.NewTraces() | ||
currentTraceID := pcommon.NewTraceIDEmpty() | ||
|
||
tracesSeq(func(traces []ptrace.Traces) bool { | ||
for _, trace := range traces { | ||
resources := trace.ResourceSpans() | ||
// TODO: add non-empty requirement to contract | ||
mahadzaryab1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
traceID := resources.At(0).ScopeSpans().At(0).Spans().At(0).TraceID() | ||
if currentTraceID == pcommon.NewTraceIDEmpty() { | ||
currentTrace = trace | ||
currentTraceID = traceID | ||
mahadzaryab1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} else if currentTraceID == traceID { | ||
// TODO: merge traces | ||
mahadzaryab1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
} else { | ||
if !yield(currentTrace) { | ||
mahadzaryab1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
return false | ||
} | ||
currentTrace = ptrace.NewTraces() | ||
currentTraceID = pcommon.NewTraceIDEmpty() | ||
} | ||
} | ||
return true | ||
}) | ||
|
||
if currentTraceID != pcommon.NewTraceIDEmpty() { | ||
mahadzaryab1 marked this conversation as resolved.
Show resolved
Hide resolved
|
||
yield(currentTrace) | ||
} | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.