Skip to content

[v2][adjuster] Remove error return from adjuster interface #6383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • This PR removes the error return value from the v2 adjuster interface as none of the adjusters return any errors and errors instead recorded on the spans as warnings.

How was this change tested?

  • CI

Checklist

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.20%. Comparing base (9ddc9a4) to head (bc52738).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6383      +/-   ##
==========================================
+ Coverage   96.18%   96.20%   +0.02%     
==========================================
  Files         361      361              
  Lines       20614    20602      -12     
==========================================
- Hits        19828    19821       -7     
+ Misses        601      597       -4     
+ Partials      185      184       -1     
Flag Coverage Δ
badger_v1 9.05% <ø> (ø)
badger_v2 1.64% <ø> (ø)
cassandra-4.x-v1-manual 15.01% <ø> (ø)
cassandra-4.x-v2-auto 1.59% <ø> (ø)
cassandra-4.x-v2-manual 1.59% <ø> (ø)
cassandra-5.x-v1-manual 15.01% <ø> (ø)
cassandra-5.x-v2-auto 1.59% <ø> (ø)
cassandra-5.x-v2-manual 1.59% <ø> (ø)
elasticsearch-6.x-v1 18.78% <ø> (ø)
elasticsearch-7.x-v1 18.85% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v1 19.01% <ø> (ø)
elasticsearch-8.x-v2 1.64% <ø> (ø)
grpc_v1 10.69% <ø> (ø)
grpc_v2 7.96% <ø> (ø)
kafka-v1 9.37% <ø> (ø)
kafka-v2 1.64% <ø> (ø)
memory_v2 1.64% <ø> (ø)
opensearch-1.x-v1 18.90% <ø> (ø)
opensearch-2.x-v1 18.89% <ø> (-0.01%) ⬇️
opensearch-2.x-v2 1.63% <ø> (ø)
tailsampling-processor 0.47% <ø> (ø)
unittests 95.04% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yurishkuro yurishkuro merged commit 7537fe9 into jaegertracing:main Dec 18, 2024
56 checks passed
@mahadzaryab1 mahadzaryab1 deleted the remove-adjuster-error branch January 6, 2025 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants