[refractor] Switch to enums for ES mappings

[Saumya40-codes]

Which problem is this PR solving?

• Resolves [hygiene] Use enum instead of a string #6067
• Follows up refactor: use enum instead of strings for ES mappings #6068

Description of the changes

• Currently in plugin/storage/es/mappings/mapping.go we are using bare string inorder to for the file mapping. This PR refractors this approach to use enums instead of string

How was this change tested?

• running go test in respective files/directories

Checklist

• I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
• I have signed all commits
• I have added unit tests for the new functionality
• I have run lint and test steps successfully
  • for jaeger: make lint test
  • for jaeger-ui: yarn lint and yarn test

[codecov]

Codecov Report

Attention: Patch coverage is 95.74468% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.92%. Comparing base (bec885e) to head (7d1ccdd).
Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
cmd/es-rollover/app/init/action.go	66.66%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6091      +/-   ##
==========================================
- Coverage   96.93%   96.92%   -0.01%     
==========================================
  Files         352      352              
  Lines       16719    16742      +23     
==========================================
+ Hits        16206    16227      +21     
- Misses        329      330       +1     
- Partials      184      185       +1     

Flag	Coverage Δ
badger_v1	7.97% <0.00%> (-0.02%)	⬇️
badger_v2	1.84% <0.00%> (-0.01%)	⬇️
cassandra-4.x-v1	15.71% <0.00%> (-0.04%)	⬇️
cassandra-4.x-v2	1.77% <0.00%> (-0.01%)	⬇️
cassandra-5.x-v1	15.71% <0.00%> (-0.04%)	⬇️
cassandra-5.x-v2	1.77% <0.00%> (-0.01%)	⬇️
elasticsearch-6.x-v1	19.10% <51.35%> (+0.03%)	⬆️
elasticsearch-7.x-v1	19.16% <51.35%> (+0.03%)	⬆️
elasticsearch-8.x-v1	19.34% <51.35%> (+0.02%)	⬆️
elasticsearch-8.x-v2	1.83% <0.00%> (-0.02%)	⬇️
grpc_v1	9.35% <0.00%> (-0.03%)	⬇️
grpc_v2	7.10% <0.00%> (-0.02%)	⬇️
kafka-v1	9.66% <0.00%> (-0.03%)	⬇️
kafka-v2	1.84% <0.00%> (-0.01%)	⬇️
memory_v2	1.84% <0.00%> (-0.01%)	⬇️
opensearch-1.x-v1	19.22% <51.35%> (+0.06%)	⬆️
opensearch-2.x-v1	19.21% <51.35%> (+0.03%)	⬆️
opensearch-2.x-v2	1.83% <0.00%> (-0.02%)	⬇️
tailsampling-processor	0.49% <0.00%> (-0.01%)	⬇️
unittests	95.74% <95.74%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[yurishkuro]

Patch coverage is 61.70213% with 18 lines in your changes missing coverage.

Can we improve test coverage for the new code?

[Saumya40-codes]

Patch coverage is 61.70213% with 18 lines in your changes missing coverage.

Can we improve test coverage for the new code?

Should we add tests for MappingTypeFromString function? I'm not seeing any other way to make it get into test coverages of mapping_test

[yurishkuro]

The codecov comment #6091 (comment) shows all missing coverage. Is there any reason not to test all gaps?

[Saumya40-codes]

The codecov comment #6091 (comment) shows all missing coverage. Is there any reason not to test all gaps?

We were missing out on testing MappingTypeFromString part which is now covered
I think it should be good now!

[Saumya40-codes]

Anything else I'm missing on @yurishkuro ?

[yurishkuro]

Thanks!