Collect code coverage from integration tests and upload to codecov #4964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4964 +/- ##
==========================================
- Coverage 96.42% 95.59% -0.83%
==========================================
Files 304 317 +13
Lines 18092 18689 +597
==========================================
+ Hits 17445 17866 +421
- Misses 513 661 +148
- Partials 134 162 +28
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
added
the
changelog:ci
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
commented
Nov 24, 2023
| .PHONY: token-propagation-integration-test | ||
| token-propagation-integration-test: | ||
| go clean -testcache | ||
| bash -c "set -e; set -o pipefail; $(GOTEST) -tags token_propagation -run TestBearTokenPropagation $(STORAGE_PKGS) | $(COLORIZE)" |
Member
Author
There was a problem hiding this comment.
was not used anywhere
yurishkuro
commented
Nov 24, 2023
| GOFUMPT=gofumpt | ||
| FMT_LOG=.fmt.log | ||
| IMPORT_LOG=.import.log | ||
| COLORIZE ?= | $(SED) 's/PASS/✅ PASS/g' | $(SED) 's/FAIL/❌ FAIL/g' | $(SED) 's/SKIP/☠️ SKIP/g' |
Member
Author
There was a problem hiding this comment.
Changed COLORIZE macro to include | ... so that it can be overwritten to nothing for faster std output. When output is piped, even to | cat -, the buffering prevents incremental test output, so one cannot easily observe test progress
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
changed the title
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
albertteoh
approved these changes
Nov 25, 2023
| codecov: | ||
| notify: | ||
| require_ci_to_pass: yes | ||
| after_n_builds: 11 |
Member
Author
There was a problem hiding this comment.
that's how many reports we upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
.nocoversince their packages are now included in coverage via integration tests anyway. Add correspondingempty_test.goto avoid linter error.printlnfrom badger & sampling storage integration| ...so that it can be overwritten to nothing for faster std output. When output is piped, even to| cat -, the buffering prevents incremental test output, so one cannot easily observe test progressHow was this change tested?