Skip to content

Conversation

@sameersecond
Copy link
Contributor

@sameersecond sameersecond commented Sep 18, 2023

Which problem is this PR solving?

Resolves #4561

Description of the changes

  • Include compaction window settings based on the 'COMPACTION_WINDOW' environment variable
  • The value of the compaction window is either provided by the user or by calculating ceil(ttl / 30)

How was this change tested?

Locally tested change by generating the CSQL code from the template.
Can reproduce by running:

$ MODE=test ./create.sh v004.cql.tmpl

$ TRACE_TTL=2592000 MODE=test ./create.sh v004.cql.tmpl

$ COMPACTION_WINDOW=12h MODE=test ./create.sh v004.cql.tmpl

Checklist

- Include compaction window settings based on the 'COMPACTION_WINDOW' environment variable

Signed-off-by: Sameer Kavthekar <[email protected]>
@sameersecond sameersecond requested a review from a team as a code owner September 18, 2023 15:07
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@yurishkuro yurishkuro enabled auto-merge (squash) September 18, 2023 16:58
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@yurishkuro yurishkuro merged commit a53ddaf into jaegertracing:main Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

With ScyllaDB (and likely Cassandra too), increasing TTL leads to large numbers of sstables

3 participants