Support configurable metrics backend in the agent #275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
black-adder
approved these changes
Jul 17, 2017
cmd/agent/main.go
Outdated
| "go.uber.org/zap" | ||
|
|
||
| "fmt" |
cmd/agent/main.go
Outdated
| @@ -36,15 +36,16 @@ func main() { | |||
| builder.Bind(flag.CommandLine) | |||
| flag.Parse() | |||
|
|
|||
| fmt.Printf("%+v\n", builder) | |||
pkg/metrics/builder.go
Outdated
| // Builder provides command line options to configure metrics backend used by Jaeger executables. | ||
| type Builder struct { | ||
| Backend string | ||
| HTTPRoute string |
There was a problem hiding this comment.
HTTPScrapeEndpoint? or at least a comment
There was a problem hiding this comment.
will add a comment. It's not always for scraping.
| } | ||
| mf, err := b.CreateMetricsFactory("foo") | ||
| if testCase.err != nil { | ||
| assert.Equal(t, err, testCase.err) |
There was a problem hiding this comment.
no, it's an error object here
| continue | ||
| } | ||
| require.NotNil(t, mf) | ||
| if testCase.handler { |
There was a problem hiding this comment.
nit: could probably remove the handler variable and just do:
route != ""
| if testCase.handler { | ||
| require.NotNil(t, b.handler) | ||
| mux := http.NewServeMux() | ||
| b.RegisterHandler(mux) |
There was a problem hiding this comment.
is there anyway to check if this function actually worked?
There was a problem hiding this comment.
we could start an http server and query it, but feels like overkill
cmd/agent/app/builder_test.go
Outdated
| "go.uber.org/zap" | ||
| "gopkg.in/yaml.v2" | ||
|
|
||
| "github.com/uber/jaeger-lib/metrics" |
added 6 commits
July 17, 2017 18:26
Defaults to expvar. Prometheus metrics currently don't work because it does not allow dots in the names (jaegertracing/jaeger-lib#20) and requires pre-declaring all tag keys, which is not supported by the Jaeger's metrics API.
yurishkuro
force-pushed
the
agent-metrics
branch
from
07eee17 to
6196067
Compare
ideepika
pushed a commit
to ideepika/jaeger
that referenced
this pull request
Oct 22, 2017
Defaults to expvar. Prometheus metrics currently don't work because it does not allow dots in the names (jaegertracing/jaeger-lib#20) and requires pre-declaring all tag keys, which is not supported by the Jaeger's metrics API.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults to expvar. Prometheus metrics currently don't work because
it does not allow dots in the names (jaegertracing/jaeger-lib#20)
and requires pre-declaring all tag keys, which is not supported by
the Jaeger's metrics API.
Re: https://github.com/uber/jaeger/issues/273