-
Notifications
You must be signed in to change notification settings - Fork 591
Remove duplicate Antd dependencies #3193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3193 +/- ##
=======================================
Coverage 97.92% 97.92%
=======================================
Files 260 260
Lines 8142 8144 +2
Branches 2114 2145 +31
=======================================
+ Hits 7973 7975 +2
Misses 169 169 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Yuri Shkuro <[email protected]>
|
@yurishkuro I upgrade v2.12.0 to v2.13.0 and service tags are really low contrast now. I think this is the PR responsible.
If you look at ant examples, tags are supposed to contrast with the background:
This is pretty low contrast, but it's better than nothing. In Jaeger search results our background seems to match that of the whole surrounding trace block, making it disappear. v5.x was a lot better at it in my opinion with the border being explicit:
|
|
@bobrik yeah, it looked better before. We cannot undo the upgrade, have to move forward, but it's more likely the style changes are due to are internal overrides of the styles, e.g. here
When I was making theming changes in #1911 I was trying to match the before style but the before was already after AntD v6 upgrade. |
|
I opened #3202 to bring back the outline. |




After we upgraded to AntD v6 we should've removed the use of
"@ant-design/compatible"which was still pulling in v5 and creating some issues.Also in this change:
allowClearattribute to input text boxesclear searchbutton from in-page search sinceallowClearworks the same way