Skip to content

Conversation

@yurishkuro
Copy link
Member

@yurishkuro yurishkuro commented Nov 29, 2025

After we upgraded to AntD v6 we should've removed the use of "@ant-design/compatible" which was still pulling in v5 and creating some issues.

Also in this change:

  • remove unnecessary vite plugin that was extending antd imports
  • add allowClear attribute to input text boxes
  • remove clear search button from in-page search since allowClear works the same way
  • AI also fixed scripts/get-tracking-version.js that was causing warnings

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 29, 2025
@yurishkuro yurishkuro marked this pull request as ready for review November 29, 2025 03:25
@yurishkuro yurishkuro requested a review from a team as a code owner November 29, 2025 03:25
@yurishkuro yurishkuro requested review from mahadzaryab1 and removed request for a team November 29, 2025 03:25
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@codecov
Copy link

codecov bot commented Nov 29, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.92%. Comparing base (0676b57) to head (2988570).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3193   +/-   ##
=======================================
  Coverage   97.92%   97.92%           
=======================================
  Files         260      260           
  Lines        8142     8144    +2     
  Branches     2114     2145   +31     
=======================================
+ Hits         7973     7975    +2     
  Misses        169      169           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit e4afea7 into main Nov 29, 2025
11 checks passed
@yurishkuro yurishkuro deleted the fix-antd6-theme branch November 29, 2025 03:53
@bobrik
Copy link
Contributor

bobrik commented Dec 4, 2025

@yurishkuro I upgrade v2.12.0 to v2.13.0 and service tags are really low contrast now. I think this is the PR responsible.

  • Before:
image
  • After:
image

If you look at ant examples, tags are supposed to contrast with the background:

image

This is pretty low contrast, but it's better than nothing. In Jaeger search results our background seems to match that of the whole surrounding trace block, making it disappear.

v5.x was a lot better at it in my opinion with the border being explicit:

image

@yurishkuro
Copy link
Member Author

@bobrik yeah, it looked better before. We cannot undo the upgrade, have to move forward, but it's more likely the style changes are due to are internal overrides of the styles, e.g. here

const lightTheme: ThemeConfig = {

When I was making theming changes in #1911 I was trying to match the before style but the before was already after AntD v6 upgrade.

@bobrik
Copy link
Contributor

bobrik commented Dec 5, 2025

I opened #3202 to bring back the outline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants