Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 28, 2025

Completes the NameSelector → SearchableSelect migration started in #3182. Removes the now-unused NameSelector component.

Changes

  • DeepDependencies/Header: Replace NameSelector with SearchableSelect for Service and Operation dropdowns
  • QualityMetrics/Header: Replace NameSelector with SearchableSelect for Service dropdown
  • Delete NameSelector: Remove NameSelector.tsx, NameSelector.css, NameSelector.test.js

Migration Pattern

Follows the same approach as TraceStatisticsHeader in #3182:

// Before (NameSelector)
<NameSelector
  label="Service"
  placeholder="Select a service…"
  value={service || null}
  setValue={setService}
  required
  options={services || []}
/>

// After (SearchableSelect)
<label className="DdgHeader--label">
  <span className="DdgHeader--labelText">Service:</span>
  <SearchableSelect
    value={service || null}
    onChange={setService}
    placeholder="Select a service…"
    status={!service ? 'error' : undefined}
    fuzzy
  >
    {(services || []).map(opt => (
      <Select.Option key={opt} value={opt}>{opt}</Select.Option>
    ))}
  </SearchableSelect>
</label>

Key differences:

  • Label prefix in separate <span> with custom styling
  • onChange instead of setValue
  • allowClear/onClear for optional fields
  • status="error" for required field validation

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • iojs.org
    • Triggering command: /usr/bin/curl curl -q --fail --compressed -L -s REDACTED -o - (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

in the PR 3182 we migrated TransStatisticsHeader from NameSelector to SearchableSelect. I now want to complete the migration and do the same for DeepDependencies/Header and QualityMetrics/Header components. In the same PR let's delete NameSelector component and its related files.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…lector to SearchableSelect and delete NameSelector files

Co-authored-by: yurishkuro <[email protected]>
Copilot AI changed the title [WIP] Complete migration of components to SearchableSelect Migrate DeepDependencies/Header and QualityMetrics/Header from NameSelector to SearchableSelect Nov 28, 2025
Copilot AI requested a review from yurishkuro November 28, 2025 22:39
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Nov 28, 2025
@codecov
Copy link

codecov bot commented Nov 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.92%. Comparing base (96b996f) to head (1f732d0).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3185      +/-   ##
==========================================
- Coverage   97.93%   97.92%   -0.01%     
==========================================
  Files         260      259       -1     
  Lines        8169     8141      -28     
  Branches     2153     2114      -39     
==========================================
- Hits         8000     7972      -28     
  Misses        169      169              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro marked this pull request as ready for review November 28, 2025 22:56
@yurishkuro yurishkuro requested a review from a team as a code owner November 28, 2025 22:56
@yurishkuro yurishkuro requested review from albertteoh and removed request for a team November 28, 2025 22:56
@yurishkuro yurishkuro merged commit a5c1b5e into main Nov 28, 2025
14 of 18 checks passed
@yurishkuro yurishkuro deleted the copilot/migrate-deep-dependencies-header branch November 28, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants