Remove the history instance from the App component #3100
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
This pr is work towards removing of history package because neither
react-router-dom v6norv7recommends it.It's safe to remove the
historyinstance from this component because React router'sRedirectcomponent handles navigation internally using the router's built-in history mechanism, not our customhistoryinstance. When we remove thehistoryprop and switch toBrowserRouter, React Router automatically falls back to using the browser'swindow.historyapi. TheRedirectcomponent works with any router that provides a history context, and our test (should handle root path redirect) prove this by verifying that when users visit the root path/, they correctly see theSearchTracePagecomponent rendered.How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test