Skip to content

Conversation

@Parship999
Copy link

@Parship999 Parship999 commented Sep 27, 2025

Which problem is this PR solving?

Description of the changes

  • This pr is work towards removing of history package because neither react-router-dom v6 nor v7 recommends it.

  • It's safe to remove the history instance from this component because React router's Redirect component handles navigation internally using the router's built-in history mechanism, not our custom history instance. When we remove the history prop and switch to BrowserRouter, React Router automatically falls back to using the browser's window.history api. The Redirect component works with any router that provides a history context, and our test (should handle root path redirect) prove this by verifying that when users visit the root path /, they correctly see the SearchTracePage component rendered.

How was this change tested?

  • unit tests

Checklist

@Parship999 Parship999 requested a review from a team as a code owner September 27, 2025 15:41
@Parship999 Parship999 requested review from jkowall and removed request for a team September 27, 2025 15:41
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 27, 2025

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.16%. Comparing base (d97ab8b) to head (635d9e8).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3100   +/-   ##
=======================================
  Coverage   98.16%   98.16%           
=======================================
  Files         257      257           
  Lines        8068     8070    +2     
  Branches     2035     2037    +2     
=======================================
+ Hits         7920     7922    +2     
  Misses        148      148           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro
Copy link
Member

please explain in the description why you're removing it, why is it safe to remove.

@Parship999
Copy link
Author

please explain in the description why you're removing it, why is it safe to remove.

Done, explanation added in the description

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for good description!

@yurishkuro yurishkuro added the changelog:refactoring Internal, non-functional code improvements label Sep 28, 2025
@yurishkuro yurishkuro merged commit 063acdf into jaegertracing:main Sep 28, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:refactoring Internal, non-functional code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants