Skip to content

Conversation

@JeevaRamanathan
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • convert packages/jaeger-ui/src/components/SearchTracePage/SearchResults/DiffSelection.tsx from class to functional and improved test cases.

How was this change tested?

  • Ensured there is no break in the functionality in UI
  • Ran the test suite using npm run test to ensure all test cases pass.
image

Checklist

@JeevaRamanathan JeevaRamanathan requested a review from a team as a code owner September 9, 2025 16:45
@JeevaRamanathan JeevaRamanathan requested review from joe-elliott and removed request for a team September 9, 2025 16:45
@graphite-app
Copy link
Contributor

graphite-app bot commented Sep 9, 2025

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@codecov
Copy link

codecov bot commented Sep 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.14%. Comparing base (30a402d) to head (8b0b079).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3076      +/-   ##
==========================================
- Coverage   98.14%   98.14%   -0.01%     
==========================================
  Files         257      257              
  Lines        8081     8080       -1     
  Branches     2039     2117      +78     
==========================================
- Hits         7931     7930       -1     
  Misses        150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:refactoring Internal, non-functional code improvements label Sep 13, 2025
@yurishkuro yurishkuro added this pull request to the merge queue Sep 13, 2025
Merged via the queue into jaegertracing:main with commit 1e7053e Sep 13, 2025
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:refactoring Internal, non-functional code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants