Skip to content

Conversation

@Parship999
Copy link

Which problem is this PR solving?

Description of the changes

  • Converted the following components to functional components:
    • BannerText.tsx
    • CountCard.tsx
    • MetricCard.tsx
    • ScoreCard.tsx
  • Added React.memo to maintain the same performance optimization that PureComponent provided

How was this change tested?

  • All tests are passing

Checklist

@Parship999 Parship999 requested a review from a team as a code owner June 2, 2025 14:00
@Parship999 Parship999 requested review from joe-elliott and removed request for a team June 2, 2025 14:00
@graphite-app
Copy link
Contributor

graphite-app bot commented Jun 2, 2025

How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Signed-off-by: Parship Chowdhury <[email protected]>
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.39%. Comparing base (dd65633) to head (fef474e).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2856      +/-   ##
==========================================
- Coverage   97.39%   97.39%   -0.01%     
==========================================
  Files         256      256              
  Lines        7975     7973       -2     
  Branches     2084     2009      -75     
==========================================
- Hits         7767     7765       -2     
  Misses        208      208              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yurishkuro yurishkuro added the changelog:refactoring Internal, non-functional code improvements label Jun 7, 2025
@yurishkuro yurishkuro added this pull request to the merge queue Jun 7, 2025
Merged via the queue into jaegertracing:main with commit 98e76e2 Jun 7, 2025
11 of 12 checks passed
@Parship999 Parship999 changed the title Convert QualityMetrics components to functional components Convert QualityMetrics components from class components to functional components Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:refactoring Internal, non-functional code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants