Skip to content

Conversation

@tejas-raskar
Copy link
Contributor

Which problem is this PR solving?

Description of the changes

  • Displayed the copy actions in a floating container instead of a separate column, making the table simpler with only 2 columns
  • Minimized the margin on the right
  • This allowed the valueMarkup to take up the remaining space within the table

Before:
Screenshot From 2025-05-24 23-05-46

After:
Screenshot From 2025-05-24 23-04-46

How was this change tested?

  • Tested the changes across different browser sizes
  • Ran npm run lint and npm run test

Screenshot From 2025-05-24 22-57-13
Screenshot From 2025-05-24 22-58-25

Checklist

@tejas-raskar tejas-raskar requested a review from a team as a code owner May 24, 2025 17:40
@tejas-raskar tejas-raskar requested review from jkowall and removed request for a team May 24, 2025 17:40
@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label May 24, 2025
@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.03%. Comparing base (c4cfc67) to head (be11288).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2814   +/-   ##
=======================================
  Coverage   97.03%   97.03%           
=======================================
  Files         256      256           
  Lines        7947     7947           
  Branches     2003     2003           
=======================================
  Hits         7711     7711           
  Misses        236      236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

}

.KeyValueTable--row:not(:hover) > .KeyValueTable--copyColumn > .KeyValueTable--copyIcon {
.KeyValueTable--row:not(:hover) .KeyValueTable--copyContainer .KeyValueTable--copyIcon {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is child syntax removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copyContainer is now nested inside the second <td> and therefore is not a direct child of the row

@yurishkuro yurishkuro changed the title feat: allow json logs to occupy entire available width Allow json logs to occupy entire available width May 24, 2025
@yurishkuro yurishkuro enabled auto-merge May 24, 2025 19:15
@yurishkuro yurishkuro added this pull request to the merge queue May 24, 2025
Merged via the queue into jaegertracing:main with commit 580b8e5 May 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: log JSON wrapping

2 participants