Fix array return pattern in LabeledList component
#2812
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Parship Chowdhury <[email protected]>
Member
|
I don't understand what problem this solves. |
Author
This PR fixes a react best practices violation that can cause console warning. current code returns a raw array from the map function. React documentation recommends wrapping array returns in Fragments with proper keys |
yurishkuro
added
the
changelog:bugfix-or-minor-feature
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2812 +/- ##
=======================================
Coverage 97.03% 97.03%
=======================================
Files 256 256
Lines 7947 7947
Branches 2003 2055 +52
=======================================
Hits 7711 7711
Misses 236 236 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
approved these changes
May 24, 2025
Merged
via the queue into
jaegertracing:main
with commit May 24, 2025
022b068
10 of 11 checks passed
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 31, 2025
## Which problem is this PR solving? While working on some other issues in the codebase, I found additional components with similar React Fragment and key issues. These components had the same React Fragment and key patterns (like in #2812 ) that needed to be solved for consistency and react best practices ## Description of the changes 1. `KeyValuesTable.tsx` - Changed `<>` to `<React.Fragment key={i}>` for proper key attribution 2. `highlightMatches.tsx` - Ensured consistent return types by wrapping plain strings in `<span>` elements - Added proper keys to all elements returned from map function 3. `SearchResults/index.tsx` - Added keys to `React.Fragment` elements in conditional rendering ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Parship Chowdhury <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The
LabeledListcomponent currently returns an array from its map function without proper React Fragment keys.Issues:
Description of the changes
<li>element to the React.FragmentChecklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test