Skip to content

Conversation

@Parship999
Copy link

@Parship999 Parship999 commented May 23, 2025

Which problem is this PR solving?

Description of the changes

  • UI Enhancements:

    • Redesigned the "VS" separator with a circular badge design for clearer visual separation between traces
    • Added subtle interactive effects to provide better feedback to users
    • Improved the empty state visualization to better represent the comparison relationship
    • Added two action buttons to the empty state:
      • "Go to Search" button to help users find traces to compare
      • "Learn how to compare traces" button linking to the medium blog post about trace diffs
  • Additional Changes(Non UI):

    • Added new traceDiff config section with configurable help links in default-config.tsx
    • TypeScript best practices with lowercase primitives (Number, Boolean) to lowercase (number, boolean)

Checklist

Before:

Screenshot 2025-05-23 160609

After:

Screenshot 2025-05-24 090700

Before:

Screenshot 2025-05-23 160650

After:

Screenshot 2025-05-23 161140

@Parship999 Parship999 requested a review from a team as a code owner May 23, 2025 11:10
@Parship999 Parship999 requested review from pavolloffay and removed request for a team May 23, 2025 11:10
@Parship999 Parship999 force-pushed the enhance-tracediff-ui-backup branch from aa8a8a8 to 579b06f Compare May 23, 2025 11:17
Signed-off-by: Parship Chowdhury <[email protected]>
@codecov
Copy link

codecov bot commented May 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.32%. Comparing base (483d574) to head (228a504).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2806   +/-   ##
=======================================
  Coverage   97.31%   97.32%           
=======================================
  Files         256      256           
  Lines        7947     7951    +4     
  Branches     2077     2078    +1     
=======================================
+ Hits         7734     7738    +4     
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

yurishkuro
yurishkuro previously approved these changes May 25, 2025
@yurishkuro
Copy link
Member

please resolve merge conflict

Parship12 added 2 commits May 25, 2025 10:33
Signed-off-by: Parship Chowdhury <[email protected]>
Signed-off-by: Parship Chowdhury <[email protected]>
@Parship999 Parship999 requested a review from yurishkuro May 25, 2025 05:35
@Parship999
Copy link
Author

The chevron icon positioned in the trace title, causing it to overlap with trace content when the window was resized to smaller widths. So I moved it to flow inline with the spans count, so that it can move with the content and prevents overlap during window resizing.

Screenshot 2025-05-25 133345

Signed-off-by: Parship Chowdhury <[email protected]>
@Parship999 Parship999 changed the title Enhance TraceDiff UI components with configuration and test infrastructure updates Enhance TraceDiff UI components May 25, 2025
Signed-off-by: Parship Chowdhury <[email protected]>
@yurishkuro
Copy link
Member

yurishkuro commented May 26, 2025

the new chevron position looks a bit confusing to me. I think top-right corner was the right position. Next to the trace title/ID it is interpreted as "select", but next to timestamp etc. it reads more like "show more details".

@Parship999
Copy link
Author

@yurishkuro
I think now it's fine

Small Window:
Screenshot 2025-05-28 123046

Medium Window:
Screenshot 2025-05-28 123501

The changes are proper text wrapping in small windows, consistent chevron icon positioning, cean layout in both window sizes

Please review these changs. I'll push them once you confirm.

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label May 28, 2025
@yurishkuro yurishkuro added this pull request to the merge queue May 28, 2025
Merged via the queue into jaegertracing:main with commit e6d2c6c May 28, 2025
10 of 11 checks passed
@Parship999
Copy link
Author

@yurishkuro I had actually sent you a message earlier asking for confirmation, I was working on for the chevron icon and text wrapping in different window sizes, since you told me the new chevron position looks a bit confusing. I've attached screenshots in my last msg. The last change of chevron icon was not pushed. Would you like me to create a new PR for the change or the current chevron icon position is ok?

Current:
Screenshot 2025-05-29 071437

@yurishkuro
Copy link
Member

I thought you added the change - please do in another PR

github-merge-queue bot pushed a commit that referenced this pull request May 31, 2025
## Which problem is this PR solving?
- Related to #2806 

## Description of the changes
![Screenshot 2025-05-30
171031](https://github.com/user-attachments/assets/4cf1e1fe-6ca3-4cbf-8edb-58835ee0f721)

## Checklist
- [x] I have read
https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md
- [x] I have signed all commits
- [ ] I have added unit tests for the new functionality
- [x] I have run lint and test steps successfully
  - for `jaeger`: `make lint test`
  - for `jaeger-ui`: `npm run lint` and `npm run test`

---------

Signed-off-by: Parship Chowdhury <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Enhance visual design of TraceDiff UI Components

3 participants