Improve performance of Trace Statistics #2721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify code and avoid some not needed loops. These changes improve performance with: * large (10k) amount of spans * large (1k) amount of unique values in tags To test: 1. Run `go run cmd/tracegen/main.go -service abcd -traces 1 -spans 10000` 2. Go to Trace Statistics 3. Group by Operation Name or attr_0 With generated data, after changing selected tag in the group by dropdown, it takes few seconds less to compute the results. Signed-off-by: Damian Maslanka <[email protected]>
DamianMaslanka5
requested review from
mahadzaryab1
and removed request for
a team
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2721 +/- ##
==========================================
- Coverage 96.77% 96.76% -0.01%
==========================================
Files 256 256
Lines 7897 7892 -5
Branches 2067 2061 -6
==========================================
- Hits 7642 7637 -5
+ Misses 255 254 -1
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yurishkuro
approved these changes
Apr 19, 2025
yurishkuro
added
the
changelog:bugfix-or-minor-feature
DamianMaslanka5
added a commit
to DamianMaslanka5/jaeger-ui
that referenced
this pull request
May 28, 2025
…p is selected These changes are similar to my previous changes where I optimizing valueFirstDropdown jaegertracing#2721 To test: 1. Run go run cmd/tracegen/main.go -service abcd -traces 1 -spans 5000 1. Go to Trace Statistics page 1. Select attr_00 in Group By 1. Select attr_01 in Sub-Group (second dropdown) Time before: 1s Time after 16ms Signed-off-by: Damian Maslanka <[email protected]>
DamianMaslanka5
added a commit
to DamianMaslanka5/jaeger-ui
that referenced
this pull request
May 28, 2025
…p is selected These changes are similar to my previous changes where I optimized valueFirstDropdown jaegertracing#2721 To test: 1. Run go run cmd/tracegen/main.go -service abcd -traces 1 -spans 5000 1. Go to Trace Statistics page 1. Select attr_00 in Group By 1. Select attr_01 in Sub-Group (second dropdown) Time before: 1s Time after 16ms Signed-off-by: Damian Maslanka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify code and avoid some not needed loops.
These changes improve performance with:
To test:
go run cmd/tracegen/main.go -service abcd -traces 1 -spans 10000With generated data, after changing selected tag in the group by dropdown, it takes few seconds less to compute the results.
Before
After