-
Notifications
You must be signed in to change notification settings - Fork 574
[Feat]: Add context menu on node to DAG #2719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat]: Add context menu on node to DAG #2719
Conversation
Signed-off-by: Hariom Gupta <[email protected]>
Signed-off-by: Hariom Gupta <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2719 +/- ##
==========================================
+ Coverage 96.77% 96.78% +0.01%
==========================================
Files 256 256
Lines 7897 7938 +41
Branches 2067 2049 -18
==========================================
+ Hits 7642 7683 +41
+ Misses 255 254 -1
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Hariom Gupta <[email protected]>
Signed-off-by: Hariom Gupta <[email protected]>
}; | ||
|
||
export const renderNode = (vertex: TVertex, selectedService: string | null, uiFind?: string): ReactNode => { | ||
export const renderNode = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it good practice for a functional component to take positional arguments instead of an object form?
Which problem is this PR solving?
Description of the changes
How was this change tested?
Checklist
jaeger
:make lint test
jaeger-ui
:npm run lint
andnpm run test