Skip to content

[Feat]: Add context menu on node to DAG #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025

Conversation

hari45678
Copy link
Contributor

@hari45678 hari45678 commented Apr 15, 2025

Which problem is this PR solving?

Description of the changes

  • This PR adds a context menu that appears when the node is clicked.
  • The menu shows options:
    • View Traces: This opens the traces in a new window something like DDG
    • Focus: This focuses the current node

How was this change tested?

  • Manually

Checklist

Signed-off-by: Hariom Gupta <[email protected]>
Signed-off-by: Hariom Gupta <[email protected]>
@hari45678 hari45678 requested a review from a team as a code owner April 15, 2025 13:12
@hari45678 hari45678 requested review from mahadzaryab1 and removed request for a team April 15, 2025 13:12
Copy link

codecov bot commented Apr 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.78%. Comparing base (d3ba400) to head (8e20cdc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2719      +/-   ##
==========================================
+ Coverage   96.77%   96.78%   +0.01%     
==========================================
  Files         256      256              
  Lines        7897     7938      +41     
  Branches     2067     2049      -18     
==========================================
+ Hits         7642     7683      +41     
+ Misses        255      254       -1     
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Hariom Gupta <[email protected]>
Signed-off-by: Hariom Gupta <[email protected]>
@hari45678
Copy link
Contributor Author

It shows something like this on clicking a node
image

@yurishkuro yurishkuro added the changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements label Apr 16, 2025
};

export const renderNode = (vertex: TVertex, selectedService: string | null, uiFind?: string): ReactNode => {
export const renderNode = (
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it good practice for a functional component to take positional arguments instead of an object form?

@yurishkuro yurishkuro added this pull request to the merge queue Apr 16, 2025
Merged via the queue into jaegertracing:main with commit 9ba711a Apr 16, 2025
9 of 10 checks passed
@hari45678 hari45678 deleted the add-context-menu-to-sdg branch April 24, 2025 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:bugfix-or-minor-feature 🐞 Bug fixes, Minor Improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants