-
Notifications
You must be signed in to change notification settings - Fork 573
Improve performance when expanding/collapsing span details #2716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yurishkuro
merged 3 commits into
jaegertracing:main
from
DamianMaslanka5:improve-critical-path-perf
Apr 10, 2025
Merged
Improve performance when expanding/collapsing span details #2716
yurishkuro
merged 3 commits into
jaegertracing:main
from
DamianMaslanka5:improve-critical-path-perf
Apr 10, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess) Memoize "calculation" of criticalPathSections per span, when span is not collapsed ## Prepare data Run `go run cmd/tracegen/main.go -service abcd -traces 1 -spans 300` from the jaeger repo ## Perf difference Total render time from the profiler available in react devtools, after collapsing Tags section ### With these changes 14ms ### Changes from master 548ms Signed-off-by: Damian Maslanka <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2716 +/- ##
=======================================
Coverage 96.68% 96.69%
=======================================
Files 256 256
Lines 7884 7889 +5
Branches 2061 2060 -1
=======================================
+ Hits 7623 7628 +5
+ Misses 261 260 -1
- Partials 0 1 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Damian Maslanka <[email protected]>
Signed-off-by: Damian Maslanka <[email protected]>
yurishkuro
approved these changes
Apr 10, 2025
Thanks @yurishkuro! |
Thanks for contributing |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 28, 2025
) ~I am opening this PR without an issue, I understand that is might not be an acceptable change, feel free to close this PR if you don't agree with this change.~ Improve performance (~300ms for 500 spans) by loading tooltip only on hover * Related issue in antd repo ant-design/ant-design#48468 * My other changes which improve performance related to critical path #2716 * Towards #645, to improve general performance with large amount of spans ## Before  ## After  --------- Signed-off-by: Damian Maslanka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve performance when expanding/collapsing span details (tags/process)
Related to #645
Memoize "calculation" of criticalPathSections per span, when span is not collapsed
Prepare data
Run
go run cmd/tracegen/main.go -service abcd -traces 1 -spans 300
from the jaeger repoPerf difference
Total render time from the profiler available in react devtools, after collapsing Tags section
With these changes
14ms
Changes from master
548ms
firefox_Ddmz0w1Z7u.mp4