Skip to content

Refactor: BoundingSphereDebug optimization + javadoc #2465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

capdevon
Copy link
Contributor

@capdevon capdevon commented May 29, 2025

These changes result in a cleaner, more robust, and easier-to-understand BoundingSphereDebug implementation.

  • Refactored the BoundingSphereDebug class for improved clarity and maintainability.
  • Simplified geometry generation for the bounding sphere debug mesh.
  • Added explicit generation and coloring of three axis-aligned circles (XY: blue, XZ: green, YZ: yellow) to visually represent the bounding sphere.
  • Introduced a helper method to handle circle vertex and color data creation.
  • Improved documentation and code comments for better understanding.
  • Implemented serialization support by adding write() and read() methods for the radialSamples property.
  • Updated copyright year in the file header.
  • Removed unused or redundant class fields and code.

@yaRnMcDonuts yaRnMcDonuts added this to the v3.9.0 milestone May 29, 2025
Optimize code for geometry data generation
@capdevon capdevon changed the title Refactor: Optimize BoundingSphereDebug Class Refactor: BoundingSphereDebug optimization + javadoc Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants