-
Notifications
You must be signed in to change notification settings - Fork 573
telemetry: add support for reporting_interval #2556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is there ay other user facing impact to switching to the native filter? Since this config option only applies to TCP metrics we need to evaluate where to add this field in the API. |
IMO no, but @kyessenov can confirm this. |
|
LGTM, users are asking for this, and we need to stop EnvoyFilter method. |
done |
3944ace
to
af09735
Compare
// Optional. Reporting interval allows configuration of the time between calls out to for metrics reporting. | ||
// This currently only supports TCP metrics but we may use this for long duration HTTP streams in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe:
// Optional. Reporting interval allows configuration of the time between calls out to for metrics reporting. | |
// This currently only supports TCP metrics but we may use this for long duration HTTP streams in the future. | |
// Optional. Reporting interval allows configuration of the time between calls for metrics reporting. | |
// This currently supports TCP metrics only, but we may use this for long duration HTTP streams in the future. |
for istio/istio#41763
allow end-users config
tcp_reporting_duration
via Telemetry APIin v1.17
istio.stats
will use native filter, the default value is5s
as kuat's suggestions: istio/istio#41763 (comment)