[water] update bindings to use PyConcreteAttr #642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a cmake configuration to hide all symbols except for the binding symbols when building libWaterPythonCAPI.so on Linux systems. Otherwise these clash with symbols loaded from libLLVM.so by ROCm 7 that unconditionally loads libLLVM.so whenever torch is loaded. Arguably it shouldn't and it's a clutch, but we need to make progress ourselves without waiting for ROCm to figure it out. Signed-off-by: Alex Zinenko <[email protected]>
Upstream exposed a better mechanism via CRTP, use that instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstream exposed a better mechanism via CRTP, use that instead.
DO NOT MERGE until llvm/llvm-project#171775 lands and the LLVM SHA is bumped to include it.