[water] Add support for vector types in wave.iterate and wave.yield operations #625
+619
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements elements per thread propagation for MMA operations. Fixes iree-org#608. Signed-off-by: tyb0807 <[email protected]>
Changes: - ReadOp: Only propagate attribute to result (register), ignore memory - WriteOp: Only validate/propagate with register operand, ignore memory This fixes false positives where memory resharding was incorrectly flagged as propagation errors. Fixes iree-org#622. Signed-off-by: tyb0807 <[email protected]>
The operations now accept both WaveTensorInRegister (before conversion) and VectorOfAnyType (after conversion). Updated type compatibility and verification logic to handle both tensor and vector type combinations appropriately. Fixes iree-org#624. Signed-off-by: tyb0807 <[email protected]>
ftynse
reviewed
Dec 23, 2025
| Arg<Variadic<WaveTensorType>, "Carried values">:$iter_args, | ||
| Arg<Variadic<WaveTensorType>, "Captured values">:$captures | ||
| // Accept both WaveTensorType (before PropagateElementsPerThread) and AnyVectorOfAnyRank (after) | ||
| Arg<Variadic<AnyTypeOf<[WaveTensorType, AnyVectorOfAnyRank]>>, "Carried values">:$iter_args, |
Contributor
There was a problem hiding this comment.
Why can't this be WaveTensorInRegisters? That constraint already accepts the the tensors with no address space, tensors in register address space and 1D vectors. And we most likely don't want any vector of any rank here, which would include scalable, 0d and other nonsense.
Contributor
Author
There was a problem hiding this comment.
This is because WaveTensorInRegisters doesn't work with Variadic. I think because it's a TypeConstraint (or something like that) and not a Type.
tgymnich
reviewed
Dec 23, 2025
| std::optional<int64_t> value = hyper.getSymbolValue(name); | ||
| #ifndef NDEBUG | ||
| if (!value) { | ||
| llvm::errs() << "symbol: " << name << "\n"; |
Contributor
Contributor
|
I can adapt to the style folks use. It did accidentally click on "squash and merge" in a thus stacked PR before, polluted the other branch and had to do a bunch of force-pushing and PR re-opening to fix that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked PRs, do not merge.
The operations now accept both WaveTensorInRegister
(before conversion) and VectorOfAnyType (after conversion).
Updated type compatibility and verification logic to handle both tensor
and vector type combinations appropriately.
Fixes #624.