object.patch.addLink not returning

[kenshyx]

If no encoding is specified, ex {enc: 'base58'}, this method never returns.
Node version: 7.4.0

[kenshyx]

Same issue for object.links

[daviddias]

Thanks for reporting! Would you like to help us fixing it by adding some tests to https://github.com/ipfs/interface-ipfs-core/blob/master/src/object.js#L668 ?

[kenshyx]

Can you guide me to some docs, where can I find an IPFSFactory simple example for https://github.com/ipfs/interface-ipfs-core#nodejs? I found something on js-ipfs-api but there should be something out of the box available that I can plug and write the tests :)

[daviddias]

Absolutely, the simplest way is to:

# git clone https://github.com/ipfs/js-ipfs
# git clone https://github.com/ipfs/interface-ipfs-core
# inside interface-ipfs-core folder
> npm install
> npm link
# inside js-ipfs folder
> npm install
> npm link interface-ipfs-core
# then simply modify the tests on the interface-ipfs-core object.js file --
 https://github.com/ipfs/interface-ipfs-core/blob/master/src/object.js#L17-L35 -- and then to run the do `npm test` in the js-ipfs folder.

[kenshyx]

I found the problem, when I'm passing an ipfs hash as string and I'm not specifying any encoding it silent fails. This solves the problem. Should I open a pull request? Also I'm preparing some tests for interface-ipfs-core regarding this issue.

[daviddias]

@kenshyx yes please :) thanks for catching that!

[daviddias]

@kenshyx I believe this all got fixed and tests are ipfs-inactive/interface-js-ipfs-core#139, correct?

Closing this issue, let me know if I missed something.