urlSource.options is ignored

[mariotaku]

https://github.com/ipfs/js-ipfs-utils/blob/e582304334584c2c076ee87a85063f6e0dd7c740/src/files/url-source.js#L9

Should this options to be passed to ky.get(url, options)?

[achingbrain]

According to the API docs, urlSource does not support any options - see 'Importing a file from a URL' here: SPEC/FILES.md so the second argument to that function should probably be removed.

Is there something specific you're trying to do?

[mariotaku]

@achingbrain Yes. For example, if a url needs credentials to be downloaded, passing headers/cookies directly without having to make requests manually.

[achingbrain]

Sounds fair enough - would you like to submit a PR with a test or two that fixes the bug?

[mariotaku]

@achingbrain Sure! I'd love to do that, and I'll learn to write test for urlSource.

[achingbrain]

This is blocked on #2810

[jacobheun]

The latest version of js-ipfs-utils now passes the options, this should no longer be an issue.