feat: improve JSON errors #404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add codes for errors and send all check_error() errors out as the JSON stream
Author
|
I realized we should surface more errors when going over Flutter's code. e.g. what the Flutter team is doing with 0xe8000022 in https://github.com/flutter/flutter/blob/master/packages/flutter_tools/lib/src/ios/devices.dart |
gabebear
commented
Aug 2, 2019
| @"Status": description}); | ||
| } | ||
|
|
||
| on_error(@"Unable to mount developer disk image. (%x)", result); |
Author
There was a problem hiding this comment.
This is mostly duplicative now... but I see that people are string-matching this line in other programs so leaving it.
geekonion
pushed a commit
to geekonion/ios-deploy
that referenced
this pull request
Jun 29, 2023
* Improve JSON errors Add codes for errors and send all check_error() errors out as the JSON stream * Standardize on "Status" instead of "Description" * Better handling of the messages for both JSON and console.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add codes for errors and send all check_error() errors out as the JSON stream