Moved device database to a separate header. #266
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch info to each device entry. Updated some missing definitions. Changed the full name output string format.
…t identified. Compare hw model case insensitively (fixes J85mAP != J85MAP issue).
xproax
approved these changes
Jan 23, 2017
xproax
approved these changes
Jan 23, 2017
xproax
approved these changes
Jan 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added additional sdk and arch info to each device entry.
Updated some missing or wrong definitions.
Changed the full name output string format to
"device_id a.k.a. 'device_name' (model, sdk, arch)""device_id (hwmodel, model, sdk, arch) a.k.a. 'device_name'".It was done to ease some automated testing when working with multiple devices connected to the same Mac (the Apple TV and iOS devices use different SDKs for example). Just thought it might be helpful for others too.