Skip to content

fixing bug#334: ModularBigInteger.pow does work not with large Int/Long exponent #335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manfredscheucher wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fixing bug#334: ModularBigInteger.pow does work not with large Int/Long exponent #335

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4004342
fixing bug#334: ModularBigInteger.pow does work not with large Int/Lo…
manfredscheucher Dec 4, 2025
78c526c
fixing yet another bug (cf bug#334): ModularBigInteger.pow give wrong…
manfredscheucher Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bignum/src/commonMain/kotlin/com/ionspin/kotlin/bignum/modular/ModularBigInteger.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,8 @@ class ModularBigInteger private constructor(
var e = exponent
return if (this.modulus == BigInteger.ONE) {
creator.ZERO
} else if (e < 0) {
return inverse().pow(-e)
} else {
var residue = BigInteger.ONE
var base = this.residue
Expand All @@ -244,11 +246,11 @@ class ModularBigInteger private constructor(
}

override fun pow(exponent: Long): ModularBigInteger {
return ModularBigInteger(residue.pow(exponent) % modulus, modulus, creator)
return pow(BigInteger(exponent))
}

override fun pow(exponent: Int): ModularBigInteger {
return ModularBigInteger(residue.pow(exponent) % modulus, modulus, creator)
return pow(BigInteger(exponent))
}

override fun signum(): Int {
Expand Down
Loading