Skip to content

feat(datetime): inputModeChanged; add enterInputMode/exitInputMode #30677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(datetime): inputModeChanged; add enterInputMode/exitInputMode #30677

wants to merge 1 commit into from
+402 −752

Conversation

vunizhona
Copy link
Contributor

Issue number: resolves #30634

What is the current behavior?

  • enterInputMode/exitInputMode is not available in the datetime picker
  • inputMode status updates are not available

What is the new behavior?

  • New event: inputModeChanged on ion-datetime with payload { active: boolean }.
  • New methods: enterInputMode(scope?: 'all'|'hour'|'minute', options?: { focus?: boolean }) and exitInputMode().
  • Restrict to time, date-time, time-date, and only when numeric columns exist; robust detection (class or [numeric-input]).
  • Re-emit only when applicable; attach/detach listener to avoid duplicates.
  • Fallback event emission in tests when picker methods aren’t available; deduped via internal state.
  • Dev-only warnings via Build.isDev.

Does this introduce a breaking change?

  • Yes
  • No

@vunizhona
fix(datetime,picker): guard/dedupe input mode events
bbd55e9 
datetime: restrict enter/exit to time with numeric columns; re‑emit only when present; add robust detection + fallback (tests) with internal dedupe; gate warnings behind Build.isDev.
picker: dedupe ionInputModeChange, debounce exit inactive, toggle aria-hidden around focus.
tests: assert single active/inactive; no emit on repeated enter; none for unsupported presentations.
@vunizhona vunizhona requested a review from a team as a code owner September 10, 2025 12:46
@vunizhona vunizhona requested a review from gnbm September 10, 2025 12:46
@vercel Vercel
Copy link

vercel bot commented Sep 10, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
ionic-framework Ready Ready Preview Comment Sep 10, 2025 0:48am

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Sep 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnbm gnbm Awaiting requested review from gnbm gnbm is a code owner automatically assigned from ionic-team/framework

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(datetime/picker): public API to programmatically enter numeric input mode
1 participant
@vunizhona