Skip to content

Switch from sling to rsling #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rsjethani merged 1 commit into from
Aug 20, 2023
Merged

Switch from sling to rsling #53

rsjethani merged 1 commit into from
Aug 20, 2023

Conversation

@rsjethani
Copy link
Collaborator

@rsjethani rsjethani commented Aug 17, 2023

No description provided.

@rsjethani rsjethani linked an issue Aug 17, 2023 that may be closed by this pull request
go install for cli fails #54
Closed
@rsjethani rsjethani self-assigned this Aug 17, 2023
@rsjethani
Use rsling module instead of sling
5f2b58b 
The earlier rsjethani/sling is now a complete hard fork of dghubble/
sling with new name as rsling. So make changes in order to use
rsjethani/rsling module instead of dghubble/sling.
@rsjethani rsjethani force-pushed the switch-from-sling-to-rsling branch from 81cbefa to 5f2b58b Compare August 17, 2023 21:16
@rsjethani rsjethani marked this pull request as ready for review August 17, 2023 21:17
@rsjethani rsjethani requested a review from StefMa August 17, 2023 21:17
@StefMa
Copy link
Collaborator

StefMa commented Aug 18, 2023

can you please explain this a bit more?
Why do we have to use your fork?
What does this fix?
And are you wiling to maintain it?

@rsjethani
Copy link
Collaborator Author

rsjethani commented Aug 19, 2023

can you please explain this a bit more? Why do we have to use your fork? What does this fix? And are you wiling to maintain it?

Well technically it is not a fork anymore 😄 but kidding aside the 'fork' has many more features which makes lot of repetitive code actually become new features...but PRs were not being entertained...please see https://github.com/rsjethani/rsling#overview for more details.

I have more features and improvements planned and of course I will maintain the codebase...hell I have been doing it for over a year now...for internal projects...

StefMa
StefMa approved these changes Aug 20, 2023
View reviewed changes
Copy link
Collaborator

@StefMa StefMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with Ravi sling! 🙃

@rsjethani rsjethani merged commit 81f306f into main Aug 20, 2023
@rsjethani rsjethani deleted the switch-from-sling-to-rsling branch August 20, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefMa StefMa StefMa approved these changes

Assignees

@rsjethani rsjethani

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

go install for cli fails

3 participants

@rsjethani @StefMa