-
Notifications
You must be signed in to change notification settings - Fork 788
[SYCL][FPGA] Remove deprecation message for intel::disable_loop_pipelining attribute #6404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][FPGA] Remove deprecation message for intel::disable_loop_pipelining attribute #6404
Conversation
…ining attribute intel#6254 added the fpga_pipeline attribute and deprecated the intel::disable_loop_pipelining attribute. While this was in the pipeline, the internal decision was made to switch to properties rather than attributes for this type of thing. At this point, internal request is that (at a minimum) the deprecation message for intel::disable_loop_pipelining be removed, as we no longer plan to deprecate it. Signed-off-by: Soumi Manna <[email protected]>
Signed-off-by: Soumi Manna <[email protected]>
Failures are not related to my PR: https://github.com/intel/llvm/runs/7214257852?check_suite_focus=true Failed Tests (1): https://github.com/intel/llvm/runs/7214258579?check_suite_focus=true Failed Tests (1): |
I am assuming this will be done in a later patch? |
Signed-off-by: Soumi Manna <[email protected]>
Yes, this will be done in a later patch. |
…p_pipelining_attribute
Failure is not related to this PR: |
Thank you @premanandrao and @mendell27 for reviews. |
@intel/llvm-gatekeepers, this PR is ready to be merged. Thank you |
#6254 added the fpga_pipeline attribute and
deprecated the intel::disable_loop_pipelining attribute.
While this was in the pipeline, the internal decision was made to switch to properties
rather than attributes for this type of thing.
At this point, internal request is that (at a minimum) the deprecation message for
intel::disable_loop_pipelining be removed, as we no longer plan to deprecate it.
Optionally the intel::fpga_pipeline attribute can be removed from the frontend as well.
Signed-off-by: Soumi Manna [email protected]