[UR][L0] urProgramSetSpecializationConstants to returns error #20024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now urProgramSpcializationConstants will return UR_RESULT_ERROR_INVALID_SPEC_ID when the incorrect id is used. Signed-off-by: Zhang, Winston <[email protected]>
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Zhang, Winston <[email protected]>
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Signed-off-by: Zhang, Winston <[email protected]>
winstonzhang-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
winstonzhang-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
pbalcer
reviewed
Sep 11, 2025
| @@ -994,6 +994,66 @@ ur_result_t urProgramCreateWithNativeHandle( | |||
| return UR_RESULT_SUCCESS; | |||
| } | |||
|
|
|||
| // Helper function to validate if a specialization constant ID exists in SPIR-V | |||
| static bool isValidSpecConstantId(const uint8_t *spirvCode, size_t spirvSize, | |||
There was a problem hiding this comment.
I'm really hesitant to include spir-v parsing in UR. This isn't really the best place for this check. It should be done in the driver, or the compiler needs to provide UR with spec constant ids so the adapter can just check against a known list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now urProgramSpcializationConstants will return
UR_RESULT_ERROR_INVALID_SPEC_ID when the incorrect id is used.