-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL] Add test for type aliases as kernel parameter within free function kernel #18850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Add test for type aliases as kernel parameter within free function kernel #18850
Conversation
sycl/test/extensions/free_function_kernels/free_function_kernels_type_aliases.cpp
Outdated
Show resolved
Hide resolved
sycl/test/extensions/free_function_kernels/free_function_kernels_type_aliases.cpp
Outdated
Show resolved
Hide resolved
…ls_type_aliases.cpp Co-authored-by: aelovikov-intel <[email protected]>
…in_free_function_kernels
…s://github.com/DYNIO-INTEL/llvm into test_type_aliases_within_free_function_kernels
sycl/test/extensions/free_function_kernels/free_function_kernels_type_aliases.cpp
Show resolved
Hide resolved
I think, it is needed to add tests with C-style |
@tahonermann , do you agree? I'd expect FE's processing of them is identical and that would just bloat the test for no benefit. |
sycl/test/extensions/free_function_kernels/free_function_kernels_type_aliases.cpp
Outdated
Show resolved
Hide resolved
…in_free_function_kernels
|
@tahonermann I added typedef aliases checks in this commit 2c27f01 I am not sure if this matches what you had in mind let me know if you think it should be changed. |
I think that looks fine. |
@aelovikov-intel @lbushi25 @dklochkov-emb @tahonermann I'd appreciate an approval if everyone is aligned with the current state of the PR. |
This PR adds new test for free function kernels extension based on test plan https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/FreeFunctionKernels/test-plan.md#test-type-aliases-to-allowed-kernel-paramater-types-as-kernel-parameter
Extension spec: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc
It removes unused alias of type
accessor<int, 1, access::mode::read_write>
fromsycl/test/extensions/free_function_errors.cpp