Skip to content

[SYCL] Add test for type aliases as kernel parameter within free function kernel #18850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: sycl
Choose a base branch
from

Conversation

dyniols
Copy link
Contributor

@dyniols dyniols commented Jun 6, 2025

This PR adds new test for free function kernels extension based on test plan https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/FreeFunctionKernels/test-plan.md#test-type-aliases-to-allowed-kernel-paramater-types-as-kernel-parameter

Extension spec: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc

It removes unused alias of type accessor<int, 1, access::mode::read_write> from sycl/test/extensions/free_function_errors.cpp

@dyniols dyniols temporarily deployed to WindowsCILock June 6, 2025 14:45 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 6, 2025 15:14 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 6, 2025 15:14 — with GitHub Actions Inactive
@dyniols dyniols marked this pull request as ready for review June 9, 2025 09:00
@dyniols dyniols requested a review from a team as a code owner June 9, 2025 09:00
@dyniols dyniols requested a review from aelovikov-intel June 9, 2025 09:00
@dyniols dyniols closed this Jun 9, 2025
@dyniols dyniols reopened this Jun 9, 2025
@dyniols dyniols temporarily deployed to WindowsCILock June 9, 2025 09:00 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 9, 2025 09:45 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 9, 2025 09:45 — with GitHub Actions Inactive

struct TestClass {};
using ClassAlias = TestStruct;

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add

template <...> struct X {}
using Alias = X<...>;

and

template <N args> struct Y {};
template <M args> using Alias = Y<...>;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, will do thanks!

@dyniols dyniols temporarily deployed to WindowsCILock June 9, 2025 14:54 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 9, 2025 15:45 — with GitHub Actions Inactive
@dyniols dyniols temporarily deployed to WindowsCILock June 9, 2025 15:45 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants