-
Notifications
You must be signed in to change notification settings - Fork 769
[SYCL][E2E] Add free function kernel tests as device function and host function #18824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dyniols
wants to merge
6
commits into
intel:sycl
Choose a base branch
from
dyniols:test_free_function_as_device_and_host_functions
base: sycl
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[SYCL][E2E] Add free function kernel tests as device function and host function #18824
dyniols
wants to merge
6
commits into
intel:sycl
from
dyniols:test_free_function_as_device_and_host_functions
+142
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…device_and_host_functions
Moving PR to draft state because I need to investigate failures. |
…device_and_host_functions
Closed and reopened PR to run CI. |
sycl/test-e2e/FreeFunctionKernels/free_function_kernels_as_device_host_functions.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/FreeFunctionKernels/free_function_kernels_as_device_host_functions.cpp
Outdated
Show resolved
Hide resolved
sycl/test-e2e/FreeFunctionKernels/free_function_kernels_as_device_host_functions.cpp
Outdated
Show resolved
Hide resolved
lbushi25
reviewed
Jun 10, 2025
sycl/test-e2e/FreeFunctionKernels/free_function_kernels_as_device_host_functions.cpp
Outdated
Show resolved
Hide resolved
aelovikov-intel
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds new e2e tests for free function kernels extension based on test plan https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/FreeFunctionKernels/test-plan.md#perform-test-that-free-function-kernel-can-be-used-as-device-function-within-another-kernel
Extension spec: https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/proposed/sycl_ext_oneapi_free_function_kernels.asciidoc
The overall idea behind this test to verify if free function kernel even if marked with one of the properties (
nd_range_kernel
andsingle_task_kernel
) can still be used as device or host function.