Skip to content

[SYCL] Add a test for generated device code for the group_load_store extension #13671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 7, 2024

Conversation

aelovikov-intel
Copy link
Contributor

Only loads for now. Also adds detail::naive property to force usage of the unoptimized implementation, both for testing purposes and potential future experiments/debugging.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner May 6, 2024 21:42
…extension

Only loads for now. Also adds `detail::naive` property to force usage of
the unoptimized implementation, both for testing purposes and potential
future experiments/debugging.
@aelovikov-intel aelovikov-intel added the disable-lint Skip linter check step and proceed with build jobs label May 6, 2024
@aelovikov-intel
Copy link
Contributor Author

Next PR built on top of this one: #13673

@uditagarwal97
Copy link
Contributor

uditagarwal97 commented May 7, 2024

Also, why was the lint disabled in this PR? Is clang-format altering the auto-generated CHECKs in the test case?

@aelovikov-intel
Copy link
Contributor Author

Also, why was the lint disabled in this PR? Is clang-format altering the auto-generated CHECKs in the test case?

It complains about the first auto-generated line describing how to generate the CHECKs. Normally clang's tests have clang-format disabled so long line generated by the script is considered OK.

Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@aelovikov-intel
Copy link
Contributor Author

CUDA E2E tests failures are unrelated, CUDA AWS pre-commit workflow has been just re-enabled after being broken for weeks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
disable-lint Skip linter check step and proceed with build jobs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants