Skip to content

[SYCL][Doc]Remove APIs to get kernel by type-name #11983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -397,24 +397,6 @@ Therefore, the function `kernel_bundle::get_kernel_ids` returns an empty vector
of `kernel_id` objects if the kernel bundle was created from a bundle of state
`bundle_state::ext_oneapi_source`.

Depending on the source language, the following kernel bundle functions may be
used to query for a kernel when the kernel bundle was created from a bundle of
state `bundle_state::ext_oneapi_source`.

```
template <typename KernelName>
bool has_kernel() const noexcept;

template <typename KernelName>
bool has_kernel(const device& dev) const noexcept;

template <typename KernelName>
kernel get_kernel() const;
```

The specification for each source language tells how these functions behave and
how the `KernelName` is interpreted.

=== New kernel bundle member functions

This extensions adds the following new `kernel_bundle` member functions:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,6 @@ sycl::kernel_bundle<sycl::bundle_state::executable> kb = /*...*/;
sycl::kernel k = kb.ext_oneapi_get_kernel("foo");
```

There is no mechanism to decorate an OpenCL C kernel with a type-name, so the
forms of `kernel_bundle::has_kernel` or `kernel_bundle::get_kernel` that take a
type-name are not useful for kernels defined in OpenCL C.

=== Kernel argument restrictions

When a kernel is defined in OpenCL C and invoked from SYCL via a `kernel`
Expand Down