Skip to content

Remove element restrictions of compile-time list expressions -- SIMICS-13113 #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

lwaern-intel
Copy link
Contributor

No description provided.

@mandolaerik
Copy link
Contributor

This is welcome, but I'd prefer to do it after #34 if possible, and only allow it for #[] lists, to avoid compatibility issues.

@mandolaerik
Copy link
Contributor

Blocked by #34

@lwaern-intel
Copy link
Contributor Author

@mandolaerik Now rebased to modern day. I want to try to finally get this in.

@syssimics
Copy link
Contributor

Verification #14350182: ✅ pass

Copy link
Contributor

@mandolaerik mandolaerik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also add a test of a non-constant element in a list, but I don't insist (would not increase coverage IIUC).

@lwaern-intel
Copy link
Contributor Author

We could also add a test of a non-constant element in a list, but I don't insist (would not increase coverage IIUC).

Indeed it wouldn't, so I won't bother.

@lwaern-intel lwaern-intel changed the title Remove element restrictions of compile-time list expressions Remove element restrictions of compile-time list expressions -- SIMICS-13113 Jan 30, 2025
@lwaern-intel lwaern-intel merged commit 75d51eb into intel:main Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants