Fix immediate after callbacks not notifying about state change #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Verification #13215078: pass |
|
Right, @mandolaerik is on vacation. Requesting @JonatanWaern as reviewer. |
mandolaerik
approved these changes
Apr 4, 2024
| @@ -526,4 +526,7 @@ | |||
| <build-id _6="6287" _7="7012"><add-note> Fixed a bug where overlapping | |||
| registers would not be rejected if they were part of a bank within a group | |||
| or subdevice.</add-note></build-id> | |||
| <build-id _6="next" _7="next"><add-note> Fixed a bug where executed callbacks | |||
| posted via immediate after statements would not trigger the device state | |||
| change notifier.</add-note></build-id> | |||
There was a problem hiding this comment.
Not according to a releasenote in RELEASENOTES-1.2:
Added the --state-change-dml12 flag, allowing the use of an incomplete version of state change notifiers in DML 1.2 devices .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kinda sorta forgot about this when I wrote immediate after.
After-on-hooks doesn't have the same problem as messages can only be sent through a hook from within DML itself.