Migrate from optparse to argparse #208
Conversation
mandolaerik
commented
Sep 21, 2023
mandolaerik
commented
- Shut up linter
- Remove the --illegal-attrs flag
- Remove --illegal-attrs flag
- Remove --version, which was ignored
- Migrate from optparse to argparse
|
Verification #12224557: pass |
|
Verification #12227474: pass |
| '--no-dep-phony', dest = "no_dep_phony", action = 'store_true', | ||
| help = 'With --dep, avoid addition of a phony target for each' | ||
| parser.add_argument( | ||
| '--no-dep-phony', action='store_true', |
There was a problem hiding this comment.
So with no explicit dest the parser will parse --no-dep-phony, and turn it into no_dep_phony when genning the options? Huh.
There was a problem hiding this comment.
Yes, that's standard practice for argparse. Adn add_argument('-f', '--foo-bar', ...) stores it in foo_bar.
| @@ -2392,3 +2392,7 @@ class PINT1(PortingMessage): | |||
| types, then the value of the variable becomes 1, whereas for | |||
| `int1` in DML 1.4 the value is -1.""" | |||
| fmt = "Change int1 to uint1" | |||
|
|
|||
| warnings = {name: cls for (name, cls) in globals().items() | |||
There was a problem hiding this comment.
Just to double-check that I remember the semantics of globals() -- does it return the accessible vars defined in the current module only, or does it return the vars accessible at the top-level of the current module, no matter where they are defined?
There was a problem hiding this comment.
Somewhere inbetween, it seems -- globals() returns a dict that includes some builtin symbols like __name__, __loader__ and __builtins__, but not others like __import__.
We want to distinguish between proxy attributes and proxy interface ports
Note that compared to generate_attribute_common, the condition used by need_port_proxy_attr adds a precondition that the bank/port must be on top level. The change is still a pure refactoring since generate_attribute_common is only called in DML 1.2, which requires banks and ports to be on top level.
mandolaerik
force-pushed
the
pr/migrate-from-optparse-to-argparse
branch
from
e54543f to
cf988af
Compare
|
Verification #12247784: pass |
