Add _compat_proxy_port_ifaces param #205
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mandolaerik
commented
Sep 12, 2023
mandolaerik
commented
- Factor out params for API version ranges
- Add _compat_proxy_port_ifaces param
- Rename function
- Refactor: Re-use common function
- Add _compat_proxy_port_ifaces param
We want to distinguish between proxy attributes and proxy interface ports
Note that compared to generate_attribute_common, the condition used by need_port_proxy_attr adds a precondition that the bank/port must be on top level. The change is still a pure refactoring since generate_attribute_common is only called in DML 1.2, which requires banks and ports to be on top level.
|
Will add tests and releasenote. |
|
Verification #12174833: fail |
mandolaerik
force-pushed
the
pr/add-_compat_proxy_port_ifaces-param
branch
from
e696144 to
e9362ef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.