Skip to content

Conversation

@osenan
Copy link
Contributor

@osenan osenan commented Nov 20, 2025

Pull Request

There is not issue only for this PR, although is related to this issue

There was a test skipped because there was a typo in withr package name. Now no test should be skipped if all suggested packages are installed.

@osenan osenan requested a review from m7pr November 20, 2025 14:35
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@osenan
Copy link
Contributor Author

osenan commented Nov 20, 2025

I have read the CLA Document and I hereby sign the CLA

@osenan osenan enabled auto-merge (squash) November 20, 2025 14:36
@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2025

Unit Tests Summary

  1 files   16 suites   1m 59s ⏱️
170 tests 170 ✅ 0 💤 0 ❌
386 runs  386 ✅ 0 💤 0 ❌

Results for commit c765b67.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
draggable_buckets 💚 $8.87$ $-8.50$ $-2$ $+3$ $0$ $0$
get_dt_rows_ui 💚 $2.85$ $-2.81$ $-4$ $+1$ $0$ $0$
optionalSelectInput_ui 💚 $3.07$ $-2.86$ $-14$ $+1$ $0$ $0$
optionalSliderInputValMinMax_ui 💚 $2.44$ $-2.34$ $-1$ $+1$ $0$ $0$
plot_with_settings_ui 💚 $53.67$ $-53.47$ $-30$ $+11$ $0$ $0$
table_with_settings_ui 💚 $32.80$ $-32.65$ $-47$ $+8$ $0$ $0$
verbatim_popup_ui 💚 $7.14$ $-7.05$ $-7$ $+3$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
draggable_buckets 💚 $2.43$ $-2.33$ e2e_teal.widgets_draggable_buckets_initializes_with_default_inputs
draggable_buckets 💚 $3.38$ $-3.27$ e2e_teal.widgets_draggable_buckets_initializes_without_input
draggable_buckets 💚 $2.95$ $-2.88$ e2e_teal.widgets_draggable_buckets_moving_elements_between_buckets_updates_input
get_dt_rows_ui 💚 $2.79$ $-2.77$ e2e_teal.widgets_get_dt_rows_rows_are_settable_and_visible
optionalSelectInput_ui 💚 $2.92$ $-2.91$ e2e_teal.widgets_optionalSelectInput_initializes
optionalSliderInputValMinMax_ui 💚 $2.36$ $-2.35$ e2e_teal.widgets_optionalSliderInputValMinMax_initializes
plot_with_settings_ui 💚 $4.41$ $-4.37$ e2e_teal.widgets_plot_with_settings_buttons_have_proper_FA_icons_and_two_of_them_are_dropdowns
plot_with_settings_ui 💚 $4.20$ $-4.19$ e2e_teal.widgets_plot_with_settings_clicking_download_download_button_downloads_image_in_a_specified_format
plot_with_settings_ui 💚 $5.10$ $-5.08$ e2e_teal.widgets_plot_with_settings_expanded_image_can_be_downloaded
plot_with_settings_ui 💚 $8.68$ $-8.67$ e2e_teal.widgets_plot_with_settings_expanded_image_can_be_resized
plot_with_settings_ui 💚 $3.44$ $-3.44$ e2e_teal.widgets_plot_with_settings_initializes_with_a_plot_and_the_settings_buttons
plot_with_settings_ui 💚 $3.52$ $-3.51$ e2e_teal.widgets_plot_with_settings_it_is_possible_to_set_height_and_width_for_the_plot_on_the_third_button_dropdown_menu_without_errors
plot_with_settings_ui 💚 $4.83$ $-4.82$ e2e_teal.widgets_plot_with_settings_main_image_can_be_resized
plot_with_settings_ui 💚 $5.50$ $-5.49$ e2e_teal.widgets_plot_with_settings_scrollbar_appears_when_image_is_resized
plot_with_settings_ui 💚 $4.43$ $-4.42$ e2e_teal.widgets_plot_with_settings_the_click_on_the_download_button_in_expand_modal_opens_a_download_dropdown
plot_with_settings_ui 💚 $4.94$ $-4.92$ e2e_teal.widgets_plot_with_settings_the_click_on_the_expand_button_opens_an_overlay_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
plot_with_settings_ui 💚 $4.59$ $-4.57$ e2e_teal.widgets_plot_with_settings_the_click_on_the_resize_button_opens_a_dropdown_menu_plot_height_plot_width_plot_download_dropdown_and_dismiss_button
table_with_settings_ui 💚 $4.39$ $-4.37$ e2e_teal.widgets_table_with_settings_check_pagination_appearance_for_.txt_and_disappearance_for_.csv_for_the_first_button
table_with_settings_ui 💚 $4.31$ $-4.30$ e2e_teal.widgets_table_with_settings_check_pagination_appearance_for_.txt_and_disappearance_for_.csv_for_the_modal_on_the_second_button
table_with_settings_ui 💚 $3.88$ $-3.86$ e2e_teal.widgets_table_with_settings_clicking_download_download_button_downloads_table_in_a_specified_format
table_with_settings_ui 💚 $4.51$ $-4.50$ e2e_teal.widgets_table_with_settings_clicking_download_in_an_expand_modal_opens_dropdown_menu_with_dwnl_settings_such_as_file_type_file_name_pagination
table_with_settings_ui 💚 $4.42$ $-4.40$ e2e_teal.widgets_table_with_settings_expanded_table_can_be_downloaded
table_with_settings_ui 💚 $3.05$ $-3.05$ e2e_teal.widgets_table_with_settings_is_initialized_with_2_buttons_and_a_table
table_with_settings_ui 💚 $4.18$ $-4.16$ e2e_teal.widgets_table_with_settings_the_click_on_expand_button_opens_a_modal_with_a_table
table_with_settings_ui 💚 $4.03$ $-4.01$ e2e_teal.widgets_table_with_settings_the_click_on_the_download_button_opens_a_download_menu_with_file_type_file_name_and_download_button
verbatim_popup_ui 💚 $3.50$ $-3.49$ e2e_teal.widgets_verbatim_popup_is_initialized_with_a_button_that_opens_a_modal_with_a_verbatim_text
verbatim_popup_ui 💚 $3.54$ $-3.49$ e2e_verbatim_popup_button_can_be_disabled_and_enabled

Results for commit 64d6713

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      12  86.21%   116-121, 151-156
R/get_dt_rows.R                  13       0  100.00%
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       20      20  0.00%    83-103
R/optionalInput.R               255      79  69.02%   190, 315-389, 402-409, 411-416, 434, 436, 501, 583-596
R/panel_group.R                  39      39  0.00%    50-136
R/plot_with_settings.R          309      16  94.82%   299-305, 327, 364, 373-374, 390, 578-579, 581, 583
R/standard_layout.R              52       4  92.31%   90-93
R/table_with_settings.R         158       1  99.37%   100
R/utils.R                         7       0  100.00%
R/verbatim_popup.R              105      35  66.67%   113-114, 116, 124-155
R/white_small_well.R              7       0  100.00%
TOTAL                          1124     206  81.67%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: c765b67

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@osenan osenan added the core label Nov 20, 2025
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I thought I had found and updated all of them.

@osenan osenan merged commit fe94ad0 into main Nov 20, 2025
26 of 27 checks passed
@osenan osenan deleted the fix-typos-@main branch November 20, 2025 16:13
@llrs-roche llrs-roche self-assigned this Nov 20, 2025
@github-actions github-actions bot locked and limited conversation to collaborators Nov 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants