Skip to content

change timeout for plot_with_settings_ui #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m7pr merged 1 commit into from
Nov 20, 2025
Merged

change timeout for plot_with_settings_ui #323

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 25 additions & 24 deletions tests/testthat/test-plot_with_settings_ui.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ app_driver_pws <- function() {
)
}

longer_timeout <- 80000

# JS code to click the resize button popup.
# nolint start
Expand Down Expand Up @@ -112,7 +113,7 @@ testthat::test_that(
name = "pws",
variant = "app_driver_pws_ui"
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

# Check if there is an image.
testthat::expect_true(is_visible("#plot_with_settings-plot_main > img", app_driver))
Expand All @@ -134,10 +135,10 @@ testthat::test_that(
name = "pws",
variant = "app_driver_pws_ui"
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$run_js(click_download_popup)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

testthat::expect_equal(
app_driver$get_text("#plot_with_settings-downbutton-file_format-label"),
Expand Down Expand Up @@ -196,7 +197,7 @@ testthat::test_that(
height = 1000,
width = 1000
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)
app_driver$get_text(paste0(
"#plot_with_settings-plot-with-settings > div > div > ",
"div.teal-widgets.settings-buttons > bslib-tooltip.resize-button > div:nth-child(1)"
Expand All @@ -207,7 +208,7 @@ testthat::test_that(
app_driver$set_inputs(`plot_with_settings-expbut` = TRUE)

# Expand the plot and evaluate the output
app_driver$run_js(click_expand_popup, timeout = default_idle_timeout)
app_driver$run_js(click_expand_popup, timeout = longer_timeout)
testthat::expect_true(is_visible("#bslib-full-screen-overlay", app_driver))

# Resize button
Expand All @@ -234,10 +235,10 @@ testthat::test_that(
name = "pws",
variant = "app_driver_pws_ui"
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$run_js(click_download_popup)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)
testthat::expect_true(is_visible("#plot_with_settings-plot_main > img", app_driver))

testthat::expect_equal(
Expand Down Expand Up @@ -274,14 +275,14 @@ testthat::test_that(
height = 1000,
width = 1000
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

testthat::expect_false(is_visible("#plot_with_settings-slider_ui", app_driver))

# nolint start
app_driver$run_js(click_resize_popup)
# nolint end
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)


testthat::expect_identical(
Expand Down Expand Up @@ -317,7 +318,7 @@ testthat::test_that(
name = "pws",
variant = "app_driver_pws_ui"
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$set_inputs(`plot_with_settings-height` = 1000)
app_driver$set_inputs(`plot_with_settings-width_resize_switch` = 350)
Expand All @@ -339,10 +340,10 @@ testthat::test_that(
name = "pws",
variant = "app_driver_pws_ui"
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$run_js(click_download_popup)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

filename <- app_driver$get_download("plot_with_settings-downbutton-data_download")
testthat::expect_match(filename, "png$", fixed = FALSE)
Expand All @@ -360,10 +361,10 @@ testthat::test_that("e2e teal.widgets::plot_with_settings: expanded image can be
height = 1000,
width = 1000
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$run_js(click_expand_popup)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

plot_before <- get_active_module_pws_output(app_driver, pws = "plot_modal", attr = "src")
values <- app_driver$get_values()
Expand All @@ -377,11 +378,11 @@ testthat::test_that("e2e teal.widgets::plot_with_settings: expanded image can be
400L
)
app_driver$run_js(click_resize_popup)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$set_inputs(`plot_with_settings-height` = 1000)
app_driver$set_inputs(`plot_with_settings-width` = 350)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)
values_resized <- app_driver$get_values()

testthat::expect_equal(
Expand Down Expand Up @@ -411,13 +412,13 @@ testthat::test_that("e2e teal.widgets::plot_with_settings: expanded image can be
name = "pws",
variant = "app_driver_pws_ui"
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$run_js(click_expand_popup)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$run_js(click_download_popup)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

filename <- app_driver$get_download("plot_with_settings-downbutton-data_download")
testthat::expect_match(filename, "png$", fixed = FALSE)
Expand All @@ -432,10 +433,10 @@ testthat::test_that("e2e teal.widgets::plot_with_settings: main image can be res
name = "pws",
variant = "app_driver_pws_ui"
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$run_js(click_resize_popup)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

plot_before <- get_active_module_pws_output(app_driver, pws = "plot_main", attr = "src")

Expand Down Expand Up @@ -476,12 +477,12 @@ testthat::test_that("e2e teal.widgets::plot_with_settings: scrollbar appears whe
name = "pws",
variant = "app_driver_pws_ui"
)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$run_js(click_expand_popup)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)
app_driver$run_js(click_resize_popup)
app_driver$wait_for_idle(timeout = default_idle_timeout)
app_driver$wait_for_idle(timeout = longer_timeout)

app_driver$set_inputs(`plot_with_settings-height` = 10000)
app_driver$set_inputs(`plot_with_settings-width` = 350)
Expand Down
Loading