Skip to content

Conversation

@averissimo
Copy link
Contributor

@averissimo averissimo commented Nov 4, 2025

Pull Request

Scheduled 🕰️

Fixes #nnn

@averissimo averissimo added the core label Nov 4, 2025
@averissimo averissimo marked this pull request as ready for review November 6, 2025 15:15
@averissimo
Copy link
Contributor Author

averissimo commented Nov 6, 2025

@osenan this fixes some of the errors in scheduled jobs with widgets

Feel free to close this one and merge with your PR #322

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  --------------------------------------------------
R/basic_table_args.R             23       0  100.00%
R/draggable_buckets.R            87      87  0.00%    4-163
R/get_dt_rows.R                  13      13  0.00%    44-56
R/ggplot2_args.R                 49       0  100.00%
R/nested_closeable_modal.R       20      20  0.00%    83-103
R/optionalInput.R               255     212  16.86%   140-438, 501, 562, 568, 583-596
R/panel_group.R                  39      39  0.00%    50-136
R/plot_with_settings.R          309      16  94.82%   299-305, 327, 364, 373-374, 390, 578-579, 581, 583
R/standard_layout.R              52      20  61.54%   81-99, 106
R/table_with_settings.R         158       1  99.37%   100
R/utils.R                         7       0  100.00%
R/verbatim_popup.R              105      52  50.48%   72-87, 113-114, 116, 124-155, 176
R/white_small_well.R              7       7  0.00%    19-25
TOTAL                          1124     467  58.45%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 44c6fe1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Unit Tests Summary

  1 files   15 suites   1m 47s ⏱️
123 tests 123 ✅ 0 💤 0 ❌
325 runs  325 ✅ 0 💤 0 ❌

Results for commit 44c6fe1.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 6, 2025

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
plot_with_settings_ui 💚 $53.78$ $-3.08$ $0$ $0$ $0$ $0$
table_with_settings_ui 💚 $33.10$ $-1.83$ $0$ $0$ $0$ $0$

Results for commit 5d3c600

♻️ This comment has been updated with latest results.

@osenan osenan self-assigned this Nov 7, 2025
Copy link
Contributor

@osenan osenan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good changes! I do not see any modification for the current PR. I checked and the test work well.

@averissimo averissimo merged commit db76413 into main Nov 13, 2025
75 checks passed
@averissimo averissimo deleted the rhub_nosuggests branch November 13, 2025 12:27
@github-actions github-actions bot locked and limited conversation to collaborators Nov 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants