Sessions table view model refactoring #703
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allenhumphreys
force-pushed
the
ah/sessions-table-view-controller-refactor
branch
2 times, most recently
from
13f8114 to
4b5dca0
Compare
…imenting with schedule tab solution
allenhumphreys
force-pushed
the
ah/sessions-table-view-controller-refactor
branch
from
9899bac to
cee9fe2
Compare
allenhumphreys
commented
Jul 3, 2023
|
|
||
| keywords.removeAll() | ||
| keywords.append(objectsIn: otherKeywords) | ||
| keywords.append(realm.object(ofType: Keyword.self, forPrimaryKey: newKeyword.name) ?? newKeyword) |
Collaborator
Author
There was a problem hiding this comment.
This is no longer equivalent since it doesn't handle removals
allenhumphreys
commented
Jul 3, 2023
allenhumphreys
commented
Jul 3, 2023
|
|
||
| let currentFocusIds = Set(focuses.map { $0.name }) | ||
| other.focuses.forEach { newFocus in | ||
| let effectiveFocus: Focus |
Collaborator
Author
There was a problem hiding this comment.
The existing logic doesn't handle removals, should we fix that?
Collaborator
Author
There was a problem hiding this comment.
(that's true for all 3 lists that get updated here)
allenhumphreys
commented
Jul 3, 2023
allenhumphreys
commented
Jul 3, 2023
allenhumphreys
commented
Jul 3, 2023
| targets: ["ConfCore"]) | ||
| ], | ||
| dependencies: [ | ||
| .package(url: "https://github.com/apple/swift-collections.git", from: "1.0.4"), |
Collaborator
Author
There was a problem hiding this comment.
Not in use anymore
insidegui
approved these changes
Jul 4, 2023
Owner
insidegui
left a comment
insidegui
left a comment
There was a problem hiding this comment.
Looking good! Haven't found any issues living on this build for a couple of days :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify how the table data source gets it's data and receives updated results from storage and how that is then combined with filtering predicates.
A structural change that will help make it simpler to convert to diffable datasource and/or leverage SwiftUI or move to outline view, etc. It's just simpler.