Include cabal-version field into cabal files generated with hpack #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpack includes this field itself when it's called from the command line. Without this field cabal may fail to parse generated cabal files
angerman
approved these changes
Apr 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you run hpack from the command line, it puts
cabal-versioninto generated cabal file, in addition to the result ofrenderPackagefunction. This field defines which features the cabal file may use, and may also affect parsing. For example, parsing of thelicensefield depends oncabal-version: haskell/cabal#5050, so without it cabal will fail to parse generated file for apackage.yamllike this:This PR makes sure this field is included when hpack is used