Skip to content

Conversation

crepererum
Copy link
Collaborator

Snappy is a bit more messy than the other formats, but that's what IOx currently writes via rdkafka. Implementing this allows a slightly smoother transition since we don't need to drain the compressed data from our active Kafka clusters.

Copy link
Contributor

@domodwyer domodwyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still like the feature flag approach 😂

@crepererum crepererum changed the title feat: support Snappy (de)compression feat: support Snappy (de)compression Feb 3, 2022
@crepererum crepererum changed the title feat: support Snappy (de)compression feat: support Snappy (de)compression Feb 3, 2022
@crepererum crepererum added the automerge Instruct kodiak to merge the PR label Feb 3, 2022
@kodiakhq kodiakhq bot merged commit c5bd35f into main Feb 3, 2022
@crepererum crepererum deleted the crepererum/snappy_compression branch February 16, 2022 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Instruct kodiak to merge the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants