feat: support gzip compression #82
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crepererum
force-pushed
the
crepererum/gzip_compression
branch
2 times, most recently
from
e344242 to
0a7aeda
Compare
- Also capture content from `log` crate - Play nice w/ Rust's libtest message capture
crepererum
force-pushed
the
crepererum/gzip_compression
branch
from
0a7aeda to
290991e
Compare
crepererum
force-pushed
the
crepererum/gzip_compression
branch
from
290991e to
cc23297
Compare
crepererum
force-pushed
the
crepererum/gzip_compression
branch
from
cc23297 to
c3f9bf2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we technically don't want to emit compressed data for IOx, I'm worried that some backup / cluster tool will compress our messages anyways and we end up in some incident not being able to read the data any longer.
The primary contribution of this PR is to figure out how compression works. Adding more types can be done later and should be rather easy, since they all follow the same pattern (i.e. a compressed block that follows the number of records).