chore: drop pin-project-lite
#246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually we don't need this, all our nested types fall roughly into three categories: - **no perf critical:** Use `Box::pin` to create a new allocation `Pin<Box<T>>` - **already alloated:** They where already wrapped in a `Box<T>` (e.g. for enums with vastly different variants), so `Pin<Box<T>>` is the same overhead. - **`Unpin`:** Some upstream types implement `Unpin`, so you can just use `Pin::new(&mut x)`.
crepererum
force-pushed
the
crepererum/drop_pin_project_lite
branch
from
b69911f to
e8c97af
Compare
alamb
approved these changes
Aug 6, 2024
There was a problem hiding this comment.
Looks like easier to follow code and fewer dependencies. 👍 thank you @crepererum
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually we don't need this, all our nested types fall roughly into three categories:
Box::pinto create a new allocationPin<Box<T>>Box<T>(e.g. for enums with vastly different variants), soPin<Box<T>>is the same overhead.Unpin: Some upstream types implementUnpin, so you can just usePin::new(&mut x).