feat: sasl auth impl #216
feat: sasl auth impl #216
Conversation
|
I see the commit msg checker fails here. You can probably squash everything into a single commit and mention the other two authors in the new "mega commit. See https://docs.github.com/en/pull-requests/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors on how to do this. |
- PLAIN [WIP]: Address review comments. [WIP] - Rust format WIP: Handle version 0 and 1 for SaslAuthenticateRequest WIP - Expose SaslConfig struct from Client WIP: Fix clippy errors WIP: Rust fmt checks WIP: Add client SASL test WIP: Run Sasl integration test for Kafka Skip Redpanda test, Updated README feat: add sasl authentication Adds PLAIN sasl authentication [WIP]: Address review comments. [WIP] - Rust format WIP: Handle version 0 and 1 for SaslAuthenticateRequest WIP - Expose SaslConfig struct from Client WIP: Fix clippy errors WIP: Rust fmt checks WIP: Add client SASL test WIP: Run Sasl integration test for Kafka
Co-authored-by: Ram Kumar Rengaswamy <[email protected]> Co-authored-by: Seiji Kasahar <[email protected]>
| pub(crate) fn auth_bytes(&self) -> Vec<u8> { | ||
| match self { | ||
| Self::Plain { username, password } => { | ||
| let mut auth: Vec<u8> = vec![0]; |
There was a problem hiding this comment.
IIRC I was asking for this in the original PR but it got lost in the meantime: could you add a link to the SASL spec that describes the PLAIN auth. I think this is https://datatracker.ietf.org/doc/html/rfc4616.
There was a problem hiding this comment.
This makes so much sense.
|
All updated now. |
|
thank you 🙂 |
You're welcome! Not to be selfish in anyway, but I wanted to ask if there's a release cycle for this package? |
On demand, I try to get a release out in the next couple of days. |
Ok. Thanks! Looking forward to the next release.😀 |
|
@toondaey 0.5.0 is released ✅ |
Closes #
Describe your proposed changes here.